feat(BA-532): Add configurable directory permission for vfolders #3510
+29
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 21, 2025
github-actions
bot
added
comp:manager
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
fregataa
changed the title
fregataa
force-pushed
the
topic/12-20-feat_enable_per-user_uid_gid_set_for_containers
branch
2 times, most recently
from
97bf1d8 to
08c0f58
Compare
fregataa
force-pushed
the
topic/01-21-feat_add_configurable_directory_permission_for_vfolders
branch
from
ab70964 to
2886177
Compare
2 tasks
| @@ -350,6 +353,7 @@ class Params(TypedDict): | |||
| { | |||
| t.Key("volume"): t.String(), | |||
| t.Key("vfid"): tx.VFolderID(), | |||
| t.Key("mode", default=None): t.Null | t.Int, | |||
There was a problem hiding this comment.
Is it not possible to set the value of DEFAULT_VFOLDER_PERMISSION_MODE as a default argument?
| case _: | ||
| raise GroupNotFound(extra_data=group_id_or_name) | ||
|
|
||
| vfolder_permission_mode = 0o775 if container_uid is not None else None |
There was a problem hiding this comment.
Is it not possible to use the value of DEFAULT_VFOLDER_PERMISSION_MODE here as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3481 (BA-532)
Checklist: (if applicable)
📚 Documentation preview 📚: https://sorna--3510.org.readthedocs.build/en/3510/
📚 Documentation preview 📚: https://sorna-ko--3510.org.readthedocs.build/ko/3510/