-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update minimum supported TLS version to 1.2. #182
Conversation
Thanks, looks reasonable. Can we get away without a code-owners file, is it some sort of a requirement on your side? We will ask you to collapse your patches into a single commit so that we can merge clearly, i.e., your identity will be there forever in the git tree, isn't that enough? |
Yes sorry, I will remove the codeowners file (it was intended for our
internal fork).
…On Wed, Dec 4, 2024, 04:02 Gabor Retvari ***@***.***> wrote:
Thanks, looks reasonable.
Can we get away without a code-owners file, is it some sort of a
requirement on your side? We will ask you to collapse your patches into a
single commit so that we can merge clearly, i.e., your identity will be
there forever in the git tree, isn't that enough?
—
Reply to this email directly, view it on GitHub
<#182 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BM27UK2CHLLIH4YXJA7P43T2D3AITAVCNFSM6AAAAABS6GMFSGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMJWGYYTGNBSGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Required internally.
@rg0now deleted. Can you check again pls? |
Very nice, thanks. Last request: can you collapse the whole thing into a single commit? I think if I squash-merge you lose your authorship (is that true?), but if I merge as is we mess up the git history with lots of useless commits. Wdyt? |
Gabor, I can - I'm going to open a new PR though, because my local commit log is messed up. |
No description provided.