Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minimum supported TLS version to 1.2. #182

Closed
wants to merge 8 commits into from

Conversation

notdurson
Copy link
Contributor

No description provided.

@rg0now
Copy link
Member

rg0now commented Dec 4, 2024

Thanks, looks reasonable.

Can we get away without a code-owners file, is it some sort of a requirement on your side? We will ask you to collapse your patches into a single commit so that we can merge clearly, i.e., your identity will be there forever in the git tree, isn't that enough?

@notdurson
Copy link
Contributor Author

notdurson commented Dec 4, 2024 via email

Required internally.
@notdurson
Copy link
Contributor Author

@rg0now deleted. Can you check again pls?

@rg0now
Copy link
Member

rg0now commented Dec 5, 2024

Very nice, thanks. Last request: can you collapse the whole thing into a single commit? I think if I squash-merge you lose your authorship (is that true?), but if I merge as is we mess up the git history with lots of useless commits. Wdyt?

@notdurson
Copy link
Contributor Author

Gabor, I can - I'm going to open a new PR though, because my local commit log is messed up.

@notdurson notdurson closed this Dec 5, 2024
@notdurson notdurson deleted the min-tls-12 branch December 5, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants