fix: Make turncat build on Windows
#111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will rerun tests once github is back online.. (https://www.githubstatus.com/) |
done |
rg0now
reviewed
Jan 9, 2024
|
|
||
| func reuseAddr(network, address string, conn syscall.RawConn) error { | ||
| return conn.Control(func(descriptor uintptr) { | ||
| _ = syscall.SetsockoptInt(syscall.Handle(descriptor), syscall.SOL_SOCKET, syscall.SO_REUSEADDR, 1) |
There was a problem hiding this comment.
Quick question: wouldn't syscall.Handle(descriptor) work on UNIX too? Maybe that's the portable way to use syscalls
There was a problem hiding this comment.
That would be great. Unfortunately, Handle is defined for windows only.
rg0now
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it was mentioned in #81,
turncatfails to build on windows.The build error:
Proposed fix:
Split system specific code and control build process with
//go:builddirectives.Build works on linux/windows. Tested on Windows 10 22H2 and go 1.21.5.
Comments and testers are welcome. :)