Update CloudRetro helper script #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the fact that UDPRoutes aren't followed by their respective services anymore, but having a service for the Gateway itself, this value of the helper-script should have been changed.
rg0now
requested changes
Jan 3, 2024
There was a problem hiding this comment.
Nice, thanks! Quick requests:
- Can you please update the installation instructions in the README here to not install the
stunnerHelm chart (not needed anymore)? It is best if you do not provide your own installation instructions anyway, just point the reader to the official docs. - Update the auth type
plaintexttostaticin the YAMLs and the docs. - Change protocol names (
UDP->TURN-UDP,TCP->TURN-TCP, etc) in the YAMLs and the docs.
- Updated Stunner installation part - Updated `plaintext` authtype to `static` - Replaced `UDP` with `TURN-UDP` at Stunner resources
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the fact that UDPRoutes aren't followed by their respective services anymore, but having a service for the Gateway itself, this value of the helper-script should have been changed.