fix: LoggerFactory now emits loggers at the correct loglevel

pkg/logger/logger.go

@@ -145,7 +145,6 @@ func (f *RateLimitedLoggerFactory) NewLogger(scope string) logging.LeveledLogger
 	// disable rate-limiting logging at lower loglevels
 	l := f.DefaultLogLevel
 
-	// this will never happen: loggers are always created with the default loglevel
 	scopeLevel, found := f.ScopeLevels[scope]
 	if found {
 		l = scopeLevel
@@ -184,7 +183,13 @@ func (f *LeveledLoggerFactory) newLogger(scope string, limit rate.Limit, burst i
 		return logger
 	}
 
-	l := NewRateLimitedLoggerForScope(scope, f.DefaultLogLevel, f.Writer, limit, burst)
+	logLevel := f.DefaultLogLevel
+	scopeLevel, found := f.ScopeLevels[scope]
+	if found {
+		logLevel = scopeLevel
+	}
+
+	l := NewRateLimitedLoggerForScope(scope, logLevel, f.Writer, limit, burst)
 
 	l.DefaultLeveledLogger.
 		WithTraceLogger(log.New(l.RateLimitedWriter, fmt.Sprintf("%s TRACE: ", scope), defaultFlags)).

pkg/logger/logger_test.go

@@ -317,6 +317,44 @@ var loggerTests = []loggerTestCase{
 			log.Debug("dummy")
 			assert.Zerof(t, loglenr(), "DEBUG for level %s", level)
 
+			log.Trace("dummy")
+			assert.Zerof(t, loglenr(), "TRACE for level %s", level)
+		},
+	},
+	{
+		name:            "set-loglevel-for-newly-created-logger",
+		defaultLogLevel: "all:TRACE",
+		scopeLogLevel:   "TRACE",
+		prep: func(lf LoggerFactory) {
+			lf.SetLevel("all:error,new-scope:DEBUG")
+		},
+		tester: func(t *testing.T, lf LoggerFactory) {
+			level := lf.GetLevel("all")
+			assert.Equal(t, "Error", level, "default scope: level")
+
+			level = lf.GetLevel(testScope)
+			assert.Equal(t, "Error", level, "dummy scope: level")
+
+			level = lf.GetLevel("new-scope")
+			assert.Equal(t, "Debug", level, "new scope: level")
+
+			log := lf.NewLogger("new-scope")
+
+			level = lf.GetLevel("new-scope")
+			assert.Equal(t, "Debug", level, "new scope: level")
+
+			log.Error("dummy")
+			assert.Containsf(t, logreadr(), "dummy", "ERROR for level %s", level)
+
+			log.Warn("dummy")
+			assert.Containsf(t, logreadr(), "dummy", "WARN for level %s", level)
+
+			log.Info("dummy")
+			assert.Containsf(t, logreadr(), "dummy", "INFO for level %s", level)
+
+			log.Debug("dummy")
+			assert.Containsf(t, logreadr(), "dummy", "DEBUG for level %s", level)
+
 			log.Trace("dummy")
 			assert.Zerof(t, loglenr(), "TRACE for level %s", level)
 		},