fix: Fix splitdim tests

l7mp · Oct 12, 2023 · 871fd6c · 871fd6c
1 parent 4ddd98b
commit 871fd6c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/99-labs/03-splitdim/README.md b/99-labs/03-splitdim/README.md
@@ -367,7 +367,7 @@ Before we start, below is a list of useful functions that help dealing with enco
    - return HTTP 400 error status (`http.StatusBadRequest`) if any of these checks fail,
    - log the request, 
    - call `db.Transfer` to process the request (this will currently call the placeholder, we will implement this in the next step),
-   - return HTTP 500 error status (`http.StatusInternalServerError`) if something went wrong and write the error message into the response body,
+   - return HTTP 400 error status (`http.StatusBadRequest`) if something went wrong and write the error message into the response body,
    - if all went well, return HTTP 200 (`http.StatusOK`).
    
 1. Implement the `db.Transfer(t)` call from the above. This will require extending the below function in the `pkg/db/local` package:

diff --git a/99-labs/code/splitdim/transfer_test.go b/99-labs/code/splitdim/transfer_test.go
@@ -25,7 +25,12 @@ func TestTransfer(t *testing.T) {
 	assert.Equal(t, http.StatusBadRequest, res.StatusCode, "status")
 
 	// test with wrong JSON
-	res, err = testHTTP(t, "api/transfer", "POST", `{"a":12}`)
+	res, err = testHTTP(t, "api/transfer", "POST", `{"a":12`)
+	assert.NoError(t, err, "POST: api/transfer")
+	assert.Equal(t, http.StatusBadRequest, res.StatusCode, "status")
+
+	// test with same sender and receiver
+	res, err = testHTTP(t, "api/transfer", "POST", `{"sender":"a", "receiver": "a", "amount": 12}`)
 	assert.NoError(t, err, "POST: api/transfer")
 	assert.Equal(t, http.StatusBadRequest, res.StatusCode, "status")