Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ban #196

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Ban #196

wants to merge 1 commit into from

Conversation

alimtunc
Copy link
Contributor

@alimtunc alimtunc commented Nov 2, 2022

DO NOT MERGE IF #163 ISN'T MERGED

Adding ban feature on report modal

Capture d’écran 2022-11-02 à 17 12 59

@Donorhan
Copy link
Contributor

Donorhan commented Nov 4, 2022

I merged the #163, it was impossible to merge a PR on another from a PR coming from a fork. But it causes a conflict, if you don't have time I can take care of the rebase 🙂

@alimtunc
Copy link
Contributor Author

alimtunc commented Nov 7, 2022

@Donorhan Should be good now 🙂

Copy link
Contributor

@ramnes ramnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This "Report & Ban" button is weird. As an admin, I want to ban users that have been reported to me, not report users that I ban. Also, it would make the "ban" button hard to find. Can we put that button on the users list just like the one to kick users? Ideally we'd also want the button in the reports we receive. Maybe we can also add both the "kick" and "ban" buttons in the radial menu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants