-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Best Constrained Path Menu #56
base: master
Are you sure you want to change the base?
Conversation
+ Adds in support for constraints + Adds in support for flexibility
I am changing the UI design to support picking flexible and inflexible metrics. |
I did not have enough time to work on the UI too much - it is not much different than before. I would like another review if possible. |
Sure, I will review. |
Hello @MarvinTorres, exist a small problem when the browser is resized. The map doesn’t adjust creating a blank bar below the map. A first, solution to this problem is to disable the scrollbar on the map. But this solution reduces the responsive. Solution: <style type="text/css">
body{
overflow-y:hidden;
}
</style> I am looking for a better solution. |
Thank you @cmagnobarbosa, I will implement your changes. EDIT: It worked! I managed to add a new component that supports searching for flexible and inflexible metrics. Below is a W.I.P screenshot of its current iteration. Feel free to comment on it - its design is tentative. |
- self.v4_is_flexible[checked] was comparing strings, not boolean. - Will need to change code to use bools
- "Best Constrained Path With Flexible Metrics" now "Best Constrained Path" - Original "Best Constrained Path" menu removed since it was redundant - v3 endpoint removed - v4 endpoint changed to v2/best-constrained-paths - variable names changed to reflect removed menu
Hello everyone, I updated the UI once more. To demonstrate this, I added a GIF that shows the updated UI in the original post. |
@rmotitsuki I would like to add a compact version of this menu. But I was unable to find documentation on how to do so. I could be missing something, though. I could implement a simplified menu, but I would like to design it such that it does not show up in the uncompacted version. But I have no idea where to begin implementing that design. If you would help me, I would appreciate it. |
@MarvinTorres |
@rmotitsuki Thank you for your help! I will look up the source files as you suggested. If I have any more questions I will let you know. |
Hello @MarvinTorres, I was testing your user interface and it's great, thanks bro! I have a question: If I selected an Undesired Link, can I deselect it? |
@gleybersonandrade I messed with the UI a bit and found that I could unselect an option by clicking on it while holding |
@MarvinTorres sure, so simple! :) Thanks man |
@gleybersonandrade @rmotitsuki @josemauro @cmagnobarbosa I would like to merge the Best Path and Best Constrained Path accordion items into one menu. Let me know what you think of that idea. |
- Added "Minimum Flexible Hits" text to menu - Changed "maximum_misses" var name to "minimum_flexible_hits"
This helps resolve #22
Demo of current iteration:
This updates the UI to support searches for multiple shortest constrained flexible paths. This change affects only the interface - the logic will be the subject of a separate pull request.
Elements Added:
Screenshots:
Open
Closed