Skip to content
This repository has been archived by the owner on Apr 22, 2024. It is now read-only.

Prompt user to reenter credentials when create napps upload fails and KeyboardInterrupt handled on create_napp() #284

Closed
wants to merge 8 commits into from

Conversation

slinksoft
Copy link
Contributor

@slinksoft slinksoft commented Jul 1, 2020

The Capstone 1 team at FIU attempted to solve issue #222 . We added if statements to check for a specific 401 UNAUTHORIZED error that involved an invalid/expired token.

We also attempted to solve issue #212 , which simply was solved by catching a KeyboardInterrupt exception on create_napp()

@slinksoft slinksoft changed the title Prompt user to reenter credentials when create napps upload fails Prompt user to reenter credentials when create napps upload fails and KeyboardInterrupt handled on create_napp() Jul 2, 2020
@hdiogenes
Copy link
Member

There's some weird behavior going on in Travis for this pull request, where it logs the result as "Build passed" even when some tests fail in the detailed build log: https://travis-ci.org/github/kytos/kytos-utils/builds/704405595

@hdiogenes
Copy link
Member

@slinksoft the tests are failing for this PR. Can you please run the tests with tox and try to fix them?

@slinksoft
Copy link
Contributor Author

Hello @hdiogenes . I apologize for just seeing this, as I was busy with other projects before our team's semester started.

I think as we did with our previous pull requests (mainly the ones in the kytos repo), we are going to start over with these two issues on kytos-utils, and solve each one separately so debugging is easier. Some of the errors being shown are confusing.

I'll let my team know and close this PR until we are ready to submit the fixes. Thanks,

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants