Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vue3 webpack prod script #73

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

rmotitsuki
Copy link

Summary

Fix webpack prod script, adding explicity vue3 options to compile for production.

Local Tests

  • Install the NPM dependencies npm i
  • Build the UI with production script npm run prod
  • copy build.js to /kytos/web-ui/dist/build.js
  • run kytosd
  • access Kytos UI in the browser
  • open developer console inside the browser
  • Check if there is warning messages about the compatiblity mode with vue2

@rmotitsuki rmotitsuki requested a review from a team as a code owner July 31, 2024 17:02
Copy link
Member

@viniarck viniarck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rmotitsuki, great fix, I've also tried it out locally to also help out, it worked for me too. I've noticed this WebGL: INVALID_OPERATION: drawArrays: no valid shader mensage in the console a bit strange, do you have any idea what can it be? I wonder if it's related to issue #69

20240731_144706

Other than, that feel free to merge and we'll keep making progress. Thanks, Rogerio.

@viniarck
Copy link
Member

viniarck commented Aug 2, 2024

After following this tutorial that Rogerio has forwarded to me https://askubuntu.com/questions/299345/how-to-enable-webgl-in-chrome-on-ubuntu, I enabled the Override software rendering list (I already had enabled GPU hw acceleration enabled) and the map loaded correctly and the WebGL messages went away.

The headers error still remains though cc'ing @rmotitsuki, appreciated your help. Also, in my case I didn't notice any significant higher CPU usage, I'll leave this option turned on, if I start seeing anything else alarming I'll report back.

@rmotitsuki rmotitsuki merged commit cf640a2 into kytos-ng:master Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants