forked from kytos/topology
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Retries to handle MongoDB AutoReconnect
exception
#90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajoaoff
approved these changes
May 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very good, @viniarck. Just a minor comment.
MONGO_AUTO_RETRY_STOP_AFTER_ATTEMPT MONGO_AUTO_RETRY_WAIT_RANDOM_MIN MONGO_AUTO_RETRY_WAIT_RANDOM_MAX
@ajoaoff since kytos core PR 216 has landed, I pushed this commit 66d07b5 to re-use the decorators from core |
viniarck
force-pushed
the
feature/mongo_retries
branch
from
May 24, 2022 17:39
584f30b
to
099ea44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #83
Currently,
pymongo
driver will retry once reads and writes, however it's responsibility of the application to handleAutoReconnect
, so this PR handles it accordingly and also provides a class decorator for all methods to avoid too much boilerplate, in the future, we can move this decorator to kytos core to be easily reused once other NApps start integrating with MongoDB.This PR is on top of #84
Description of the change
AutoReconnect
exceptionPractical example
pymongo
serverselectiontimeoutms
is 30s (which is configurable too), so operations are subjected to it.Prior to this PR
AutoReconnect
is raised it fails after 30s, in this case when handling a KytosEvent it would end up in the dead letter:With this PR