Merge pull request #85 from kytos-ng/fix/unpack_dict_changed_size

fix: `RuntimeError: dictionary changed size` when yielding class attributes

CHANGELOG.rst

@@ -17,6 +17,7 @@ Removed
 
 Fixed
 =====
+- Made a shallow copy of ``__dict__`` when iterating over class attributes to fix potential ``RuntimeError``
 
 Security
 

pyof/foundation/base.py

@@ -586,7 +586,7 @@ def get_class_attributes(cls):
         """
         #: see this method docstring for a important notice about the use of
         #: cls.__dict__
-        for name, value in cls.__dict__.items():
+        for name, value in cls.__dict__.copy().items():
             # gets only our (pyof) attributes. this ignores methods, dunder
             # methods and attributes, and common python type attributes.
             if GenericStruct._is_pyof_attribute(value):
@@ -605,7 +605,7 @@ def _get_instance_attributes(self):
             generator: tuples with attribute name and value.
 
         """
-        for name, value in self.__dict__.items():
+        for name, value in self.__dict__.copy().items():
             if name in map((lambda x: x[0]), self.get_class_attributes()):
                 yield (name, value)