Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fields displaying NAN values #599

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Fix fields displaying NAN values #599

merged 1 commit into from
Jan 6, 2025

Conversation

rmotitsuki
Copy link

Closes #595

Summary

Fix the form fields min. flexible hits and SPF max path changing any value that is not a number to "" (empty).

Local Tests

UI test:

  • click the mef-eline NApp
  • try entering any non-numeric value in the fields: SPF max path cost and Min. flexible hits

End-to-End Tests

@rmotitsuki rmotitsuki requested a review from a team as a code owner December 20, 2024 20:12
@HeriLFIU HeriLFIU self-requested a review January 6, 2025 17:04
HeriLFIU
HeriLFIU approved these changes Jan 6, 2025
View reviewed changes
Copy link
Collaborator

@HeriLFIU HeriLFIU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rmotitsuki I just tested out the fix and it works well. I no longer get NaN.

@HeriLFIU HeriLFIU merged commit c74f6d0 into kytos-ng:master Jan 6, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeriLFIU HeriLFIU HeriLFIU approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI: SPF max path cost and min flexible hits get stuck with NaN
2 participants
@rmotitsuki @HeriLFIU