Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI - Fix $payload undefined code #598

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Conversation

rmotitsuki
Copy link

Closes #597

Summary

Fix the error about $payload not defined, removing the offending code (line 859)
It seems a debug code that was left in the script.
All other code modifications were trailing whitespace that was automatically removed.

Local Tests

Test the UI.

  • select the mef-eline NApp
  • open the List of EVC and select one EVC from the list.
  • click Save EVC
    The logging tab will pop up the updated messege.
    No browser´s console error should be triggered.

End-to-End Tests

@rmotitsuki rmotitsuki requested a review from a team as a code owner December 20, 2024 15:49
@rmotitsuki rmotitsuki changed the title Fix $payload undefined code UI - Fix $payload undefined code Dec 20, 2024
@HeriLFIU HeriLFIU self-requested a review January 6, 2025 18:26
Copy link
Collaborator

@HeriLFIU HeriLFIU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rmotitsuki I tested it out and the fix worked well. I was able to update an EVC without getting the undefined payload error.

@HeriLFIU HeriLFIU merged commit 112063f into kytos-ng:master Jan 6, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI: Payload is undefined when changing data from an EVC
2 participants