Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: UI checkbox to request that In-band Network Telemetry (INT) gets enabled #474

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

viniarck
Copy link
Member

@viniarck viniarck commented Jun 12, 2024

Closes #180
Closes #382

This PR is on top of PR #473

Summary

  • See updated changelog file
  • Even if telemetry_int isn't installed this won't create any issue, since it's just setting a metadata value, which telemetry_int subscribes to.

Local Tests

  • UI with the checkbox checked (it set the metadata to request INT accordingly):

20240612_102746

2024-06-12 10:27:51,472 - INFO [kytos.napps.kytos/mef_eline] (AnyIO worker thread) EVC(3e68dd8231a646, inter_evpl) was deployed.
2024-06-12 10:27:51,472 - INFO [uvicorn.access] (MainThread) 127.0.0.1:52180 - "POST /api/kytos/mef_eline/v2/evc/ HTTP/1.1" 201
2024-06-12 10:27:51,472 - INFO [kytos.napps.kytos/telemetry_int] (MainThread) Handling mef_eline.deployed on EVC id: 3e68dd8231a646
2024-06-12 10:27:51,473 - INFO [kytos.napps.kytos/telemetry_int] (MainThread) Enabling INT on EVC ids: ['3e68dd8231a646'], force: True
2024-06-12 10:27:51,484 - INFO [uvicorn.access] (MainThread) 127.0.0.1:52240 - "POST /api/kytos/pathfinder/v3/ HTTP/1.1" 200
2024-06-12 10:27:51,487 - INFO [uvicorn.access] (MainThread) 127.0.0.1:52244 - "GET /api/kytos/flow_manager/v2/stored_flows?state=installed&state=pending HTTP/1.1" 200
2024-06-12 10:27:51,500 - INFO [kytos.napps.kytos/flow_manager] (AnyIO worker thread) Send FlowMod from request dpid: 00:00:00:00:00:00:00:02, command: add, force: False,  flows[0, 2]: 

20240612_102757

  • UI with checkbox not checked:

20240612_102956

End-to-End Tests

Not needed for UI

@viniarck viniarck requested a review from a team as a code owner June 12, 2024 13:35
Base automatically changed from feat/failover_link_down to master June 14, 2024 16:36
@viniarck viniarck force-pushed the feat/ui_checkbox_int branch from a3635f4 to ff001ce Compare July 8, 2024 15:21
@viniarck viniarck merged commit ad893a5 into master Jul 18, 2024
2 checks passed
@viniarck viniarck deleted the feat/ui_checkbox_int branch July 18, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant