Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleted extras #17

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Deleted extras #17

merged 1 commit into from
Jul 22, 2024

Conversation

Alopalao
Copy link

Closes #14

Summary

Deleted extras from setup.py
Added --cov-report term-missing to pytest command, kytos issue #487

Local Tests

Run tox

End-to-End Tests

N/A

@Alopalao
Deleted extras in setup.py
e71dbbd 
- Added report for missing terms in pytest run
@Alopalao Alopalao requested a review from a team as a code owner July 22, 2024 14:04
viniarck
viniarck approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@viniarck viniarck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done. Great to have this tech debt fixed.

Let's ship it.

@viniarck viniarck merged commit 61d9ff4 into master Jul 22, 2024
1 check passed
@viniarck viniarck deleted the file/setup branch July 22, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viniarck viniarck viniarck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unnecessary extras
2 participants
@Alopalao @viniarck