Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added versioning to sdntrace requests #307

Merged
merged 1 commit into from
May 30, 2024
Merged

Added versioning to sdntrace requests #307

merged 1 commit into from
May 30, 2024

Conversation

Alopalao
Copy link

@Alopalao Alopalao commented May 29, 2024

Closes #306

Summary

Depends on this PR
Added versioning to sdntrace API requests

Local Tests

N/A

End-to-End Tests

+ python3 -m pytest tests/test_e2e_40_sdntrace.py --reruns 2 -r fEr
============================= test session starts ==============================
platform linux -- Python 3.11.2, pytest-8.1.1, pluggy-1.5.0
rootdir: /tests
plugins: rerunfailures-13.0, timeout-2.2.0, anyio-4.3.0
collected 14 items

tests/test_e2e_40_sdntrace.py ..............                             [100%]

=============================== warnings summary ===============================

@Alopalao Alopalao requested a review from a team as a code owner May 29, 2024 18:40
Copy link
Member

@viniarck viniarck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Leaving it pre-approved to land with the related PRs.

@Alopalao Alopalao merged commit 3388db7 into master May 30, 2024
@Alopalao Alopalao deleted the api/sdntrace branch May 30, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update sdntrace tests with new versioning /v1/
2 participants