Adding log for number of flows

CHANGELOG.rst

@@ -88,6 +88,10 @@ Added
 - Added query parameter filter for `cookie_range` to the endpoint ``GET v2/stored_flows``.
 - Added query parameter filter for `state` to the endpoint ``GET v2/stored_flows``.
 
+Changed
+=======
+- Added flow quantity as ``total_length`` in logs for flow deletion and adittion through request and event.
+
 Fixed
 =====
 - Fixed handling ``OFPT_ERROR`` correctly when OF negotiation fails

main.py

@@ -580,9 +580,13 @@ def handle_flows_install_delete(self, event):
         try:
             dpid = event.content["dpid"]
             flow_dict = event.content["flow_dict"]
+            flows = flow_dict["flows"]
         except KeyError as error:
             log.error("Error getting fields to install or remove " f"Flows: {error}")
             return
+        except TypeError as err:
+            log.error(f"{str(err)} for flow_dict {flow_dict}")
+            return
 
         if event.name.endswith("install"):
             command = "add"
@@ -594,7 +598,7 @@ def handle_flows_install_delete(self, event):
             return
 
         try:
-            validate_cookies_and_masks(flow_dict, command)
+            validate_cookies_and_masks(flows, command)
         except ValueError as exc:
             log.error(str(exc))
             return
@@ -603,6 +607,10 @@ def handle_flows_install_delete(self, event):
             return
 
         force = bool(event.content.get("force", False))
+        if not flow_dict["flows"]:
+            log.error(f"Error, empty list of flows received. {flow_dict}")
+            return
+
         switch = self.controller.get_switch_by_dpid(dpid)
         flows_to_log_info(
             f"Send FlowMod from KytosEvent dpid: {dpid}, command: {command}, "

setup.py

@@ -99,7 +99,8 @@ class Test(TestCommand):
 
     def run(self):
         """Run tests."""
-        cmd = "python3 -m pytest tests/ %s" % self.get_args()
+        cmd = "python3 -m pytest tests/ --cov-report term-missing"
+        cmd += f" {self.get_args()}"
         try:
             check_call(cmd, shell=True)
         except CalledProcessError as exc:
@@ -115,7 +116,8 @@ class TestCoverage(Test):
 
     def run(self):
         """Run tests quietly and display coverage report."""
-        cmd = "python3 -m pytest --cov=. tests/ %s" % self.get_args()
+        cmd = "python3 -m pytest --cov=. tests/ --cov-report term-missing"
+        cmd += f" {self.get_args()}"
         try:
             check_call(cmd, shell=True)
         except CalledProcessError as exc:

tests/unit/test_main.py

@@ -650,7 +650,7 @@ def test_handle_flows_install_delete_fail(self, *args):
         # missing cookie_mask
         event = get_kytos_event_mock(
             name="kytos.flow_manager.flows.delete",
-            content={"dpid": dpid, "flow_dict": [{"cookie": 1}]},
+            content={"dpid": dpid, "flow_dict": {"cookie": 1, "flows": []}},
         )
         self.napp.handle_flows_install_delete(event)
         assert mock_log.error.call_count == 3
@@ -663,6 +663,14 @@ def test_handle_flows_install_delete_fail(self, *args):
         self.napp.handle_flows_install_delete(event)
         assert mock_log.error.call_count == 4
 
+        # empty flow list
+        event = get_kytos_event_mock(
+            name="kytos.flow_manager.flows.delete",
+            content={"dpid": dpid, "flow_dict": {"flows": []}},
+        )
+        self.napp.handle_flows_install_delete(event)
+        assert mock_log.error.call_count == 5
+
         # install_flow exceptions
         event = get_kytos_event_mock(
             name="kytos.flow_manager.flows.install",

utils.py

@@ -189,11 +189,14 @@ def validate_cookies_del(flows: list[dict]) -> None:
 
 def flows_to_log_info(message: str, flow_dict: dict[str, list]) -> None:
     """Log flows, maximun flows in a log is 200"""
+    length_msg = f"total_length: {len(flow_dict['flows'])}, "
     maximun = 200
     flows_n = len(flow_dict["flows"])
     i, j = 0, maximun
     while flow_dict["flows"][i:j]:
         log.info(
-            f"{message} flows[{i}, {(j if j < flows_n else flows_n)}]: {flow_dict['flows'][i:j]}"
+            f"{message}{length_msg} flows[{i}, {(j if j < flows_n else flows_n)}]:"
+            f" {flow_dict['flows'][i:j]}"
         )
         i, j = i + maximun, j + maximun
+        length_msg = ""