Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for ImagePullSecrets #335

Merged
merged 9 commits into from
Nov 6, 2024
Merged

Add support for ImagePullSecrets #335

merged 9 commits into from
Nov 6, 2024

Conversation

halamix2
Copy link
Member

@halamix2 halamix2 commented Oct 31, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • Add support for private Docker registries
    • currently, user has to manually create Role & RoeBinding in each namespace with enabled validation, this will be added in a separate PR

Related issue(s)

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 31, 2024
@halamix2 halamix2 force-pushed the validate-private-images branch from 3950134 to d3fb722 Compare November 6, 2024 10:53
@halamix2 halamix2 marked this pull request as ready for review November 6, 2024 10:54
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 6, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 6, 2024
@halamix2 halamix2 merged commit 14f810c into kyma-project:main Nov 6, 2024
15 checks passed
@halamix2 halamix2 deleted the validate-private-images branch November 6, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cortey Cortey Cortey approved these changes

@dbadura dbadura Awaiting requested review from dbadura

@anoipm anoipm Awaiting requested review from anoipm anoipm is a code owner

@pPrecel pPrecel Awaiting requested review from pPrecel pPrecel is a code owner

@kwiatekus kwiatekus Awaiting requested review from kwiatekus kwiatekus is a code owner

@MichalKalke MichalKalke Awaiting requested review from MichalKalke MichalKalke is a code owner

Assignees

@Cortey Cortey

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@halamix2 @Cortey @kyma-bot