Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry pick image builder #1019

Merged
merged 5 commits into from
Sep 23, 2024
Merged

Cherry pick image builder #1019

merged 5 commits into from
Sep 23, 2024

Conversation

kolodziejczak
Copy link
Contributor

@kolodziejczak kolodziejczak commented Sep 17, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

Pre-Merge Checklist

  • As a PR reviewer, verify code coverage and evaluate if it is acceptable.

Related issues

kolodziejczak and others added 2 commits September 17, 2024 12:38
@kolodziejczak @triffer
add workflow for release build with image-builder (kyma-project#1012)
ef06a9c 
* add workflow for release build with image-builder

* move image building to create release workflow

* remove separate release image build workflow

* Apply suggestions from code review

Co-authored-by: Tim Riffer <[email protected]>

---------

Co-authored-by: Tim Riffer <[email protected]>
@kolodziejczak
Move image build from steps to jobs (kyma-project#1018)
58d68d5
@kolodziejczak kolodziejczak requested a review from a team as a code owner September 17, 2024 10:39
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 17, 2024
@kolodziejczak kolodziejczak added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 18, 2024
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 23, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 23, 2024
@kolodziejczak kolodziejczak removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 23, 2024
@kyma-bot kyma-bot merged commit 16354e5 into kyma-project:release-1.8 Sep 23, 2024
23 checks passed
@kolodziejczak kolodziejczak deleted the cherry-pick-image-builder branch October 11, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@triffer triffer triffer approved these changes

Assignees

@triffer triffer

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kolodziejczak @triffer @kyma-bot