Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --expose flag to kyma app push #2254

Merged
merged 4 commits into from
Nov 25, 2024
Merged

Conversation

Cortey
Copy link
Contributor

@Cortey Cortey commented Nov 21, 2024

Description

Changes proposed in this pull request:

Added the --expose flag that creates an APIRule of type v2alpha1 for the app

Related issue(s)
#2240

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 21, 2024
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 22, 2024
@Cortey Cortey changed the title Expose flag Add --expose- flag to kyma app push` Nov 22, 2024
@Cortey Cortey changed the title Add --expose- flag to kyma app push` Add --expose flag to kyma app push Nov 22, 2024
@Cortey Cortey marked this pull request as ready for review November 22, 2024 08:35
@Cortey Cortey requested a review from a team as a code owner November 22, 2024 08:35
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 22, 2024
@Cortey Cortey enabled auto-merge (squash) November 25, 2024 08:16
Copy link
Member

@halamix2 halamix2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/joke

@kyma-bot
Copy link

@halamix2: Where do cats write notes? Scratch Paper!

In response to this:

/joke

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Cortey Cortey merged commit 871a51e into kyma-project:main Nov 25, 2024
5 checks passed
@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants