Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix crash in BGMPlayThrough::IsRunningSomewhereOtherThanBGMApp #777

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

johzzy
Copy link
Contributor

@johzzy johzzy commented Dec 6, 2024

At that time, when using the following tools to play alternately, it would crash

  • Chrome plays YouTube
  • ffmpeg capture BackgroundMusic Device:
    ffmpeg -f avfoundation -i :2 /tmp/hello.wav -y
  • ffplay plays:
    ffplay /tmp/hello.wav

This PR fixes it

@kyleneideck kyleneideck merged commit 4b7caee into kyleneideck:master Dec 6, 2024
2 checks passed
@kyleneideck
Copy link
Owner

Nice one, thanks.

@johzzy johzzy mentioned this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants