Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses the fully-qualified module path when getting the module name #78

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ralexstokes
Copy link
Contributor

The existing implementation would use "local" module name when getting the current module. This caused collisions if there were multiple submodules with the same name. This commit uses the "absolute" module name for a given module so that collisions do not occur.

I ran into this problem as I will put unit tests in a tests module for every module. The implementation of "cargo run tests-in-this-buffer" was using the "local" version so would run all the tests when I just wanted to run a few of the tests (namely those in the current module).

Updating this function to use the fully-qualified name should not break any existing use of this package and provides the functionality I would expect from a function with this name (i.e. run just the tests in this module).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant