parse: fix action recog func call as sql stmt #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Other is merged, this looks good too. |
Yaiba
force-pushed
the
fix/action-parser-sql-recog-call
branch
2 times, most recently
from
edbe246 to
1612d02
Compare
|
After this is merged, we'll need to bump Not sure how do we release on |
The module branches can be wherever appropriate. Need to look at the git history for the diffs in these modules. It's best to keep the needed changes ported to release branch anyway. |
brennanjl
force-pushed
the
fix/action-parser-sql-recog-call
branch
from
1612d02 to
d8535fd
Compare
brennanjl
approved these changes
Mar 11, 2024
jchappelow
pushed a commit
to jchappelow/kwil-db
that referenced
this pull request
Mar 11, 2024
jchappelow
pushed a commit
that referenced
this pull request
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr fix bug where action parser will parser function calls starts with SQL keywords as SQL statement.
Need to merge kwilteam/action-grammar-go#7 first, then update go mod.
This will requires kuneiform updates as well