Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setup init and autogen command support #1202

Merged
merged 1 commit into from
Jan 9, 2025
Merged

setup init and autogen command support #1202

merged 1 commit into from
Jan 9, 2025

Conversation

charithabandi
Copy link
Contributor

@charithabandi charithabandi commented Jan 7, 2025 •
edited
Loading

  • Introduce GenesisAllocs back into the genesis config
  • Added support for kwild setup init and kwild --autogen and kwild setup genesis commands
  • Bunch of other concurrency fixes
  • add the key type to the core/types Validator
  • p2p config will now take listen_address rather than port and ip

@charithabandi charithabandi marked this pull request as draft January 7, 2025 23:32
@charithabandi charithabandi marked this pull request as ready for review January 8, 2025 00:22
@charithabandi charithabandi linked an issue Jan 8, 2025 that may be closed by this pull request
Combine p2p.IP and p2p.Port into one p2p.Address #1201
Closed
@charithabandi charithabandi marked this pull request as draft January 9, 2025 17:30
@charithabandi charithabandi marked this pull request as ready for review January 9, 2025 18:24
@charithabandi charithabandi force-pushed the setup-cfg branch 4 times, most recently from f819bc4 to 3fc18b4 Compare January 9, 2025 19:47
jchappelow
jchappelow reviewed Jan 9, 2025
View reviewed changes
Copy link
Member

@jchappelow jchappelow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I think we should not allow creating a multiaddr string with an invalid port. See comment.

node/node.go Outdated Show resolved Hide resolved
jchappelow
jchappelow reviewed Jan 9, 2025
View reviewed changes
node/voting/voting.go Outdated Show resolved Hide resolved
@charithabandi charithabandi force-pushed the setup-cfg branch 2 times, most recently from 6285e46 to 53ab25f Compare January 9, 2025 20:43
@jchappelow
Copy link
Member

Thx. Please squash with a revised squashed commit msg, and merge when ready.

@charithabandi
Introduces back the setup commands such as init,
4bcaa02 
genesis, genesis-hash
Leader and Validators in the genesis config now takes keytype
fixes concurrency issues with the the tx subscription maps
p2p config now accepts listen_addr rather than port and ip
@charithabandi charithabandi merged commit 05f6a30 into kwilteam:main Jan 9, 2025
2 checks passed
@charithabandi charithabandi deleted the setup-cfg branch January 9, 2025 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchappelow jchappelow jchappelow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Combine p2p.IP and p2p.Port into one p2p.Address
2 participants
@charithabandi @jchappelow