Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are certain errors from the database that indicate failures of the DB backend itself, such as out of memory/disk or corruption etc.
Unfortunately, these were not halting the node, only resulting in failed blockchain transactions, thus non-determinism since it would still compute an apphash (likely incorrect) and commit the block:
This PR fixes that by:
pg
package detects this errorsql.ErrDBFailure
error typeFinalizeBlock
, detect this error type and cause the node to halt instead of just labeling the transaction as failed in the block result