Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow cartservice to accept POSTGRES env var #17

Merged
merged 7 commits into from
Aug 16, 2024
Merged

Conversation

tedim52
Copy link
Contributor

@tedim52 tedim52 commented Aug 15, 2024

No description provided.

Copy link

gitguardian bot commented Aug 15, 2024

⚠️ GitGuardian has uncovered 11 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
13106060 Triggered Generic High Entropy Secret fba78ab kubernetes-manifests/frontend.yaml View secret
13106060 Triggered Generic High Entropy Secret fba78ab kubernetes-manifests/frontend.yaml View secret
13106060 Triggered Generic High Entropy Secret 4e76a8c release/obd-kardinal.yaml View secret
13106060 Triggered Generic High Entropy Secret 4e76a8c release/obd-kardinal.yaml View secret
13352506 Triggered Generic High Entropy Secret 40f21de release/obd-kardinal.yaml View secret
13352506 Triggered Generic High Entropy Secret 4e76a8c release/obd-kardinal.yaml View secret
13352507 Triggered PostgreSQL Credentials 4e76a8c release/obd-kardinal.yaml View secret
13352507 Triggered PostgreSQL Credentials 40f21de release/obd-kardinal.yaml View secret
13352803 Triggered PostgreSQL Credentials 40f21de release/obd-kardinal.yaml View secret
13420233 Triggered Generic Database Assignment 4e76a8c src/cartservice/env.sh View secret
13420233 Triggered Generic Database Assignment ab83947 src/cartservice/env.sh View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@tedim52 tedim52 merged commit c88398a into main Aug 16, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants