Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: emui small design tweaks based on team feedback #1897

Merged
merged 9 commits into from
Dec 7, 2023

Conversation

Dartoxian
Copy link
Contributor

Description:

This PR includes a number of the easier emui tweaks from the december burndown:

  • Don't show copy button next to the package source
    image
  • Make the delete button have a hover
    image
  • ellipsis long enclave names on the enclaves list
    image
  • Don't include entrypoint and returns on the catalog package page
  • Dynamic package card layout
    image
  • support navigating logs with enter and shift+enter when searching
  • fix an issue with log search that was causing excessive renders, which I think was causing the ok. bug mentioned on notion.

Is this change user facing?

YES

References (if applicable):

  • December burndown notion

@Dartoxian Dartoxian requested a review from adschwartz December 5, 2023 18:38
@Dartoxian Dartoxian changed the base branch from main to bgazzard/service-logs-full-download December 7, 2023 10:16
@Dartoxian Dartoxian merged commit a1c61d0 into bgazzard/service-logs-full-download Dec 7, 2023
12 of 14 checks passed
@Dartoxian Dartoxian deleted the bgazzard/emui-lhf branch December 7, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants