-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: User service ports Traefik Docker labels #1871
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adschwartz
reviewed
Nov 29, 2023
...ib/lib/backend_impls/docker/object_attributes_provider/enclave_object_attributes_provider.go
Show resolved
Hide resolved
adschwartz
approved these changes
Nov 30, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 30, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 1, 2023
🤖 I have created a release *beep* *boop* --- ## [0.85.39](0.85.38...0.85.39) (2023-11-30) ### Features * emui package details page ([#1873](#1873)) ([e2b75b2](e2b75b2)) * User service ports Traefik Docker labels ([#1871](#1871)) ([d18f20e](d18f20e)) ### Bug Fixes * move log collector creation logic ([#1870](#1870)) ([b695e27](b695e27)) * service name collision error message ([#1863](#1863)) ([164b316](164b316)) * Update custom Nix dev deps to work on also linux ([#1862](#1862)) ([d11cd37](d11cd37)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 8, 2023
…1906) ## Description: In #1871 we added the Traefik labels to the user services so Traefik can discover them and route to them. This PR implements a reverse proxy using Traefik on Docker. The engine starts and stops Traefik. The Traefik container is automatically connected to the enclave networks. The implementation leverages what was done for the logs aggregator. ## Is this change user facing? YES ## References (if applicable): #1871
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 14, 2023
## Description: Similar to how we are adding Traefik labels for user services on Docker, we are adding a K8S ingress for each user service with a path per HTTP port so HTTP traffic can be routed to them. ## Is this change user facing? NO ## References (if applicable): #1871
h4ck3rk3y
pushed a commit
that referenced
this pull request
Dec 15, 2023
## Description: Similar to how we are adding Traefik labels for user services on Docker, we are adding a K8S ingress for each user service with a path per HTTP port so HTTP traffic can be routed to them. ## Is this change user facing? NO ## References (if applicable): #1871
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
As part of the authenticated public http ports feature, we are bringing Traefik inside the Docker cluster to route HTTP traffic to the user service HTTP ports. This PR sets the required Docker labels.
This was tested with Traefik running inside the engine enclave with the following static config and the user service enclave network added to the Traefik container list of networks.
User service "nginx" port labels:
Enclave short UUID: 65d2fb6d6732
Service short UUID: 3771c85af16a
HTTP Port number: 80
Is this change user facing?
NO
References (if applicable):
https://www.notion.so/kurtosistech/Public-user-service-HTTP-ports-bdf1107b0d1c4ca990c346fd87473174