fix: deprecate ConnectServices, remove calls to it #1853
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omar711
changed the title
laurentluce
reviewed
Nov 27, 2023
| @@ -429,6 +429,7 @@ func (enclaveCtx *EnclaveContext) GetAllFilesArtifactNamesAndUuids(ctx context.C | |||
| } | |||
|
|
|||
| // Docs available at https://docs.kurtosis.com/sdk#connectservices | |||
| // Deprecated: currently a no-op that we're removing | |||
There was a problem hiding this comment.
It is a no-op for Docker Cloud but not for the remote K8S use case where this call is relied on in the CLI Gateway.
|
Closing this for now, will wait for Gateway's removal first. The reason we can't do this right away is GetServices.
|
auto-merge was automatically disabled
November 27, 2023 20:48
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
We won't end up using
ConnectServicesso I'm removing the call to it first of all.Once this calling code is no longer running out there, we can drop the protobuf definition and linked code. Doing it all at once will probably break things post-upgrade, where people have pre-existing APICs running.
Is this change user facing?
NO
References (if applicable):