Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: static ports #1849

Draft
wants to merge 87 commits into
base: main
Choose a base branch
from
Draft

feat: static ports #1849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
87 commits
Select commit Hold shift + click to select a range
f202de5
Start a chisel server in the APIC
Nov 17, 2023
248a5ec
Try empty strings here
Nov 17, 2023
49882bc
Don't shadow variable name, drop unused config
Nov 20, 2023
5e9297d
Add tunnel port num to all methods involved in apic creation
Nov 20, 2023
d098472
Add tunnel server port spec to docker's APIC
Nov 20, 2023
09264ee
Update mock backend with new tunnel port arg
Nov 20, 2023
fc73d5b
Add tunnel port spec to Kubernetes APIC creation
Nov 20, 2023
22ab0c9
Display the relevant number in the error message
Nov 20, 2023
a7a6f64
Read tunnel port from serverArgs
Nov 20, 2023
aa83ddc
Create a portal client in all situations
Nov 20, 2023
081a4bb
Make portal client required
Nov 20, 2023
f108754
Uncertain step but we assume we'll always want portal
Nov 20, 2023
923d653
Remove the toolchain addition, seems to break build in ci
Nov 21, 2023
8494ff4
Change to get a new engine version
Nov 21, 2023
d869c47
Revert version to 1.19 (not sure why this bumped itself)
Nov 22, 2023
7ce6f71
trigger new build version
Nov 22, 2023
2d65add
Revert "trigger new build version"
Nov 22, 2023
b4ad9fa
regen protobufs following install of tools
Nov 23, 2023
03f456b
Revert "Uncertain step but we assume we'll always want portal"
Nov 23, 2023
4761169
Revert "Make portal client required"
Nov 23, 2023
c486b10
Revert "Create a portal client in all situations"
Nov 23, 2023
5a70909
Add portal client API, generate code
Nov 23, 2023
d32c825
Add boilerplate for the portal daemon build
Nov 23, 2023
bde74aa
Mirror apic init
Nov 23, 2023
cb42cb0
Wire up a basic server
Nov 23, 2023
74f589c
Add a basic portal manager. Make grpc components very obvious
Nov 23, 2023
7dcafb3
rename to portal daemon service
Nov 24, 2023
9128e17
renaming to service
Nov 24, 2023
20f3af5
Stub implementation of port forward methods / grpc
Nov 24, 2023
4fb8480
Basic validation of args based on enclave detail
Nov 24, 2023
80a36ad
Add (hardcoded) tunnel server port forwarder to the Gateway
Nov 24, 2023
ad63f80
add tunnel port info to our api container struct
Nov 24, 2023
8f99175
Comma
Nov 24, 2023
28725d0
Add tunnel port info to engine protobuf definitions of enclave info; …
Nov 24, 2023
f83ba1e
Connect up tunnel port info to api container information fields
Nov 24, 2023
8a617ae
skip validation of tunnel port; leave a note
Nov 24, 2023
0d7ffbc
Ok the bool doesn't mean anything, remove the line for now
Nov 24, 2023
7c36ed3
Account for old versions of apic which don't yet have a tunnel running
Nov 24, 2023
b073c07
Logging in engine around discovered private ports
Nov 24, 2023
8bbdb0f
Add tunnel port spec label
Nov 24, 2023
51f8d81
Logging in the gateway, see when it launches the apic connection
Nov 24, 2023
695f34c
Lookup remote port of APIC tunnel, then overwrite local port once it …
Nov 24, 2023
267a4a6
Note to self for next time: trying to get tunnel port forwarded prior…
Nov 24, 2023
44be39d
Use a channel to pass the local tunnel port back from the grpc server…
Nov 25, 2023
32e0045
Add the port forward tunnel, connect to APIC's chisel server, open tu…
Nov 25, 2023
b656a41
Drop wait until ready flag
Nov 27, 2023
dbc851e
Regen code
Nov 27, 2023
7035af3
Merge branch 'main' into omar/chisel-in-apic
Nov 27, 2023
76469d4
Add an enclave connect stub implementation for the cli
Nov 27, 2023
046cde5
Get service port autocomplete hooked up
Nov 27, 2023
adf985f
Empty disconnect command
Nov 27, 2023
9b379be
Start adding --connect flags to kurtosis run
Nov 27, 2023
fa91eea
Add support for string slice arguments
Nov 27, 2023
defd707
Fetch connect as a string slice
Nov 27, 2023
3f3a3d3
Extract service collection code to its own method
Nov 27, 2023
2231ffa
Implement the static case; combine both into one method with extracte…
Nov 27, 2023
e6f20af
Make this compile for now
Nov 27, 2023
639ecf7
Add the stringslice type
Nov 27, 2023
75cb021
Use the string slice type
Nov 27, 2023
e18ec38
Add processor
Nov 27, 2023
c34f7a4
Block default strings that aren't empty strings
Nov 27, 2023
269b1e2
Turn on validation of tunnel port as it seems to have gone missing
Nov 27, 2023
9269b3e
Add tunnel port info to enclave creation
Nov 27, 2023
0f71302
Remove daemon binary
Nov 27, 2023
41d8f45
Add a remove api call, change naming, regen
Nov 27, 2023
96de06d
introduce struct to carry enclave, service, port; we'll use this to t…
Nov 27, 2023
f663356
Make lack of optionals in forwarded service response very clear
Nov 27, 2023
4ea4f1e
Handle multiple port forwards, in the grpc layer
Nov 27, 2023
e1080b5
Missing error handler
Nov 27, 2023
97fd838
Note for tomorrow
Nov 27, 2023
332b9c7
tidy
Nov 28, 2023
47b82ca
Lint: populate fields
Nov 28, 2023
be46546
Merge branch 'main' into omar/chisel-in-apic
omar711 Nov 28, 2023
86bd592
lint: Add flag field
Nov 28, 2023
1e7815a
Add validation of args for static/ephemeral cases
Nov 28, 2023
c818f75
Note a version discontinuty in our docker checks for tunnel port
Nov 28, 2023
aefa60d
Add a little commentary
Nov 28, 2023
ba6be57
Pull kurtosis service nagivation into its own class
Nov 28, 2023
a45b647
introduce a struct to carry service details
Nov 28, 2023
95478e8
Stop complaint from goland
Nov 28, 2023
d521e70
Enumerate services, where incomplete service/port information is prov…
Nov 28, 2023
872a51c
Open udp tunnels for udp services
Nov 28, 2023
5f061a7
Specify all fields
Nov 28, 2023
fd746f9
Add validation for case where port is specified without service
Nov 28, 2023
e59b4c2
Introduce a tunnel session tracker, pull port forward create/open int…
Nov 28, 2023
a4c651d
refactor port forward tunnel to better manage lifecycle, shutdown and…
Nov 28, 2023
7d9945d
Use enclave server port as the key for tunnel tracking; hook up remov…
Nov 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions api/golang/core/kurtosis_core_rpc_api_bindings/api_container_service.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

518 changes: 272 additions & 246 deletions api/golang/engine/kurtosis_engine_rpc_api_bindings/engine_service.pb.go
View file
Open in desktop

Large diffs are not rendered by default.

164 changes: 164 additions & 0 deletions ...rpc_api_bindings/kurtosis_portal_rpc_api_bindingsconnect/portal_daemon_service.connect.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading