-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Unified REST API #1818
Merged
Merged
feat: Unified REST API #1818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lostbean
force-pushed
the
edgar/unified_restful_engine
branch
from
December 6, 2023 13:14
144f5e3
to
fabab42
Compare
rand.Seed has been deprecated since Go 1.20 and an alternative has been available since Go 1.0: Programs that call Seed and then expect a specific sequence of results from the global random source (using functions such as Int) can be broken when a dependency changes how much it consumes from the global random source. To avoid such breakages, programs that need a specific result sequence should use NewRand(NewSource(seed)) to obtain a random generator that other packages cannot access
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Dec 6, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Dec 6, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Dec 7, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Dec 7, 2023
h4ck3rk3y
added a commit
that referenced
this pull request
Dec 12, 2023
This reverts commit c3911f6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR creates unified and first class REST API to manage the Kurtosis cluster (enclaves, services, ...). The REST APIs are defined using OpenAPI 3 specs, oapi-codegen to generate server and golang bindings and echo to server it. It also server Swagger UI to allow exploring the current API documentation.
!!! WARING !!! This PR also include bumping the Go compiler to
1.20
due requirement in some of the new dependencies for OpenAPI specs.Is this change user facing?
No
References (if applicable):
BEGIN_COMMIT_OVERRIDE
feat: Unified REST API
END_COMMIT_OVERRIDE