Skip to content

Commit

Permalink
fix: remove monaco max height limit (#1823)
Browse files Browse the repository at this point in the history
## Description:
This PR removes the monaco max height limit. The limit was introduced to
prevent monaco editors becoming massive - but actually doesn't work
properly because the editor is allowed to overflow its container - as in
this screenshot:


![image](https://github.com/kurtosis-tech/kurtosis/assets/4419574/958a6bd0-d334-4582-bdb2-8af99637f6fc)


## Is this change user facing?
YES
  • Loading branch information
Dartoxian authored Nov 17, 2023
1 parent 75cba6e commit ffe0f43
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion enclave-manager/web/src/components/CodeEditor.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export const CodeEditor = ({ text, onTextChange, showLineNumbers }: CodeEditorPr
resizeEditorBasedOnContent();

return (
<Box width={"100%"} maxHeight={"1000px"}>
<Box width={"100%"}>
<Editor
onMount={handleMount}
value={text}
Expand Down
6 changes: 3 additions & 3 deletions engine/server/webapp/asset-manifest.json
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{
"files": {
"main.js": "./static/js/main.762981d8.js",
"main.js": "./static/js/main.d8d3a133.js",
"index.html": "./index.html",
"main.762981d8.js.map": "./static/js/main.762981d8.js.map"
"main.d8d3a133.js.map": "./static/js/main.d8d3a133.js.map"
},
"entrypoints": [
"static/js/main.762981d8.js"
"static/js/main.d8d3a133.js"
]
}
2 changes: 1 addition & 1 deletion engine/server/webapp/index.html
Original file line number Diff line number Diff line change
@@ -1 +1 @@
<!doctype html><html lang="en"><head><meta charset="utf-8"/><link rel="icon" href="./favicon.ico"/><meta name="viewport" content="width=device-width,initial-scale=1"/><meta name="theme-color" content="#000000"/><meta name="description" content="Kurtosis Enclave Manager"/><title>Kurtosis Enclave Manager</title><script defer="defer" src="./static/js/main.762981d8.js"></script></head><body><noscript>You need to enable JavaScript to run this app.</noscript><div id="root"></div></body></html>
<!doctype html><html lang="en"><head><meta charset="utf-8"/><link rel="icon" href="./favicon.ico"/><meta name="viewport" content="width=device-width,initial-scale=1"/><meta name="theme-color" content="#000000"/><meta name="description" content="Kurtosis Enclave Manager"/><title>Kurtosis Enclave Manager</title><script defer="defer" src="./static/js/main.d8d3a133.js"></script></head><body><noscript>You need to enable JavaScript to run this app.</noscript><div id="root"></div></body></html>

Large diffs are not rendered by default.

Large diffs are not rendered by default.

0 comments on commit ffe0f43

Please sign in to comment.