Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis CI tests in Python 2.7 and 3.5 #28

Merged
merged 9 commits into from
Apr 24, 2017
Merged

Conversation

agitter
Copy link
Contributor

@agitter agitter commented Mar 18, 2017

Updates .travis.yml to run tests in a conda 2.7 and 3.5 environment as discussed in #26. The unit tests currently fail in Python 3.5. I allowed edits from maintainers in case you want to push to this branch, or you could create a new branch and merge there instead of master.

@agitter
Copy link
Contributor Author

agitter commented Mar 21, 2017

I added a trivial test case to help me debug an error I had with SequenceDNN.plot_architecture. Even though pip installed Shapely, the line from shapely.wkt import loads as load_wkt gave me:

OSError: Could not find lib geos_c or load any of its variants ['libgeos_c.so.1', 'libgeos_c.so'].

The Travis CI server didn't have a problem with the Shapely import in my test case so it must be specific to my system. Installing Shapely with conda helped, so I added that to .travis.yml even though it is only required for some (older?) systems.

@jisraeli
Copy link
Contributor

@agitter: Thank you for reporting this issue. test_architectures.py was failing in Python 3.5 because the results of the model differed from Python 2.7, likely due to random seed difference. I added the expected results for python 3.5 and the tests now pass with both versions.

@jisraeli jisraeli merged commit 0230c39 into kundajelab:master Apr 24, 2017
@agitter agitter deleted the travis branch April 24, 2017 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants