Prefer StringBuilder.Append(char) over Append(string) (dotnet#32467)

* Prefer StringBuilder.Append(char) over Append(string) * Address PR feedback
kunalspathak · Feb 18, 2020 · 0f736f8 · 0f736f8
1 parent e7cd7bc
commit 0f736f8
Show file tree

Hide file tree

Showing 65 changed files with 240 additions and 240 deletions.
diff --git a/src/libraries/System.CodeDom/src/Microsoft/VisualBasic/VBCodeGenerator.cs b/src/libraries/System.CodeDom/src/Microsoft/VisualBasic/VBCodeGenerator.cs
@@ -379,7 +379,7 @@ private static void AppendEscapedChar(StringBuilder b, char value)
         {
             b.Append("&Global.Microsoft.VisualBasic.ChrW(");
             b.Append(((int)value).ToString(CultureInfo.InvariantCulture));
-            b.Append(")");
+            b.Append(')');
         }
 
         protected override void ProcessCompilerOutputLine(CompilerResults results, string line)

diff --git a/....ComponentModel.Composition/src/System/ComponentModel/Composition/ContractNameServices.cs b/....ComponentModel.Composition/src/System/ComponentModel/Composition/ContractNameServices.cs
@@ -91,20 +91,20 @@ internal static string GetTypeIdentityFromMethod(MethodInfo method, bool formatG
 
             WriteTypeWithNamespace(methodNameStringBuilder, method.ReturnType, formatGenericName);
 
-            methodNameStringBuilder.Append("(");
+            methodNameStringBuilder.Append('(');
 
             ParameterInfo[] parameters = method.GetParameters();
 
             for (int i = 0; i < parameters.Length; i++)
             {
                 if (i != 0)
                 {
-                    methodNameStringBuilder.Append(",");
+                    methodNameStringBuilder.Append(',');
                 }
 
                 WriteTypeWithNamespace(methodNameStringBuilder, parameters[i].ParameterType, formatGenericName);
             }
-            methodNameStringBuilder.Append(")");
+            methodNameStringBuilder.Append(')');
 
             return methodNameStringBuilder.ToString();
         }

diff --git a/...m.ComponentModel.Composition/src/System/ComponentModel/Composition/Hosting/TypeCatalog.cs b/...m.ComponentModel.Composition/src/System/ComponentModel/Composition/Hosting/TypeCatalog.cs
@@ -378,7 +378,7 @@ private string GetTypesDisplay()
                 if (builder.Length > 0)
                 {
                     builder.Append(CultureInfo.CurrentCulture.TextInfo.ListSeparator);
-                    builder.Append(" ");
+                    builder.Append(' ');
                 }
 
                 builder.Append(definition.GetPartType().GetDisplayName());

diff --git a/...ystem.Configuration.ConfigurationManager/src/System/Configuration/ConfigurationElement.cs b/...ystem.Configuration.ConfigurationManager/src/System/Configuration/ConfigurationElement.cs
@@ -1246,9 +1246,9 @@ internal void ReportInvalidLock(string attribToLockTrim, ConfigurationLockCollec
                         {
                             if (sb.Length != 0)
                                 sb.Append(", ");
-                            sb.Append("'");
+                            sb.Append('\'');
                             sb.Append(validProp.Name);
-                            sb.Append("'");
+                            sb.Append('\'');
                         }
                     }
                     else
@@ -1257,9 +1257,9 @@ internal void ReportInvalidLock(string attribToLockTrim, ConfigurationLockCollec
                         {
                             if (sb.Length != 0)
                                 sb.Append(", ");
-                            sb.Append("'");
+                            sb.Append('\'');
                             sb.Append(validProp.Name);
-                            sb.Append("'");
+                            sb.Append('\'');
                         }
                     }
                 }

diff --git a/src/libraries/System.Configuration.ConfigurationManager/src/System/Configuration/XmlUtil.cs b/src/libraries/System.Configuration.ConfigurationManager/src/System/Configuration/XmlUtil.cs
@@ -834,22 +834,22 @@ private string RetrieveFullOpenElementTag()
 
             // Start with element tag name
             StringBuilder element = new StringBuilder(64);
-            element.Append("<");
+            element.Append('<');
             element.Append(Reader.Name);
 
             // Add attributes
             while (Reader.MoveToNextAttribute())
             {
-                element.Append(" ");
+                element.Append(' ');
                 element.Append(Reader.Name);
-                element.Append("=");
+                element.Append('=');
                 element.Append('\"');
                 element.Append(Reader.Value);
                 element.Append('\"');
             }
 
             // Now close the element tag
-            element.Append(">");
+            element.Append('>');
 
             return element.ToString();
         }

diff --git a/src/libraries/System.Data.Odbc/src/Common/System/Data/Common/DbConnectionOptions.cs b/src/libraries/System.Data.Odbc/src/Common/System/Data/Common/DbConnectionOptions.cs
@@ -132,7 +132,7 @@ internal static void AppendKeyValuePairBuilder(StringBuilder builder, string key
 
             if ((0 < builder.Length) && (';' != builder[builder.Length - 1]))
             {
-                builder.Append(";");
+                builder.Append(';');
             }
 
             if (useOdbcRules)
@@ -143,7 +143,7 @@ internal static void AppendKeyValuePairBuilder(StringBuilder builder, string key
             {
                 builder.Append(keyName.Replace("=", "=="));
             }
-            builder.Append("=");
+            builder.Append('=');
 
             if (null != keyValue)
             { // else <keyword>=;

diff --git a/src/libraries/System.Data.OleDb/src/DbConnectionOptions.cs b/src/libraries/System.Data.OleDb/src/DbConnectionOptions.cs
@@ -193,7 +193,7 @@ internal static void AppendKeyValuePairBuilder(StringBuilder builder, string key
 
             if ((0 < builder.Length) && (';' != builder[builder.Length - 1]))
             {
-                builder.Append(";");
+                builder.Append(';');
             }
 
             if (useOdbcRules)
@@ -204,7 +204,7 @@ internal static void AppendKeyValuePairBuilder(StringBuilder builder, string key
             {
                 builder.Append(keyName.Replace("=", "=="));
             }
-            builder.Append("=");
+            builder.Append('=');
 
             if (null != keyValue)
             { // else <keyword>=;

diff --git a/src/libraries/System.Data.OleDb/src/OleDbConnectionString.cs b/src/libraries/System.Data.OleDb/src/OleDbConnectionString.cs
@@ -416,9 +416,9 @@ private string ValidateConnectionString(string connectionString)
 
                         StringBuilder builder = new StringBuilder();
                         builder.Append(KEY.Ole_DB_Services);
-                        builder.Append("=");
+                        builder.Append('=');
                         builder.Append(_oledbServices.ToString(CultureInfo.InvariantCulture));
-                        builder.Append(";");
+                        builder.Append(';');
                         builder.Append(connectionString);
                         connectionString = builder.ToString();
                     }

diff --git a/src/libraries/System.Data.OleDb/src/OleDbMetaDataFactory.cs b/src/libraries/System.Data.OleDb/src/OleDbMetaDataFactory.cs
@@ -218,7 +218,7 @@ private DataTable GetDataSourceInformationTable(OleDbConnection connection, OleD
                 compositeSeparatorPattern.Append(patternEscaped.ToString());
                 if ((schemaSeparatorPattern != null) && (schemaSeparatorPattern != catalogSeparatorPattern))
                 {
-                    compositeSeparatorPattern.Append("|");
+                    compositeSeparatorPattern.Append('|');
                     patternEscaped.Length = 0;
                     ADP.EscapeSpecialCharacters(schemaSeparatorPattern, patternEscaped);
                     compositeSeparatorPattern.Append(patternEscaped.ToString());

diff --git a/src/libraries/System.Data.OleDb/src/OleDb_Util.cs b/src/libraries/System.Data.OleDb/src/OleDb_Util.cs
@@ -700,7 +700,7 @@ internal static string ELookup(OleDbHResult hr)
             }
             builder.Append("(0x");
             builder.Append(((int)hr).ToString("X8", CultureInfo.InvariantCulture));
-            builder.Append(")");
+            builder.Append(')');
             return builder.ToString();
         }
 

diff --git a/src/libraries/System.Diagnostics.EventLog/src/System/Diagnostics/EventLogEntry.cs b/src/libraries/System.Diagnostics.EventLog/src/System/Diagnostics/EventLogEntry.cs
@@ -158,9 +158,9 @@ public string Message
                         {
                             if (i != 0)
                                 msgBuf.Append(", ");
-                            msgBuf.Append("'");
+                            msgBuf.Append('\'');
                             msgBuf.Append(strings[i]);
-                            msgBuf.Append("'");
+                            msgBuf.Append('\'');
                         }
 
                         msg = msgBuf.ToString();
@@ -418,9 +418,9 @@ private string GetMessageLibraryNames(string libRegKey)
                     {
                         result.Append(@"\\");
                         result.Append(owner.MachineName);
-                        result.Append(@"\");
+                        result.Append('\\');
                         result.Append(fileNames[i][0]);
-                        result.Append("$");
+                        result.Append('$');
                         result.Append(fileNames[i], 2, fileNames[i].Length - 2);
                         result.Append(';');
                     }

diff --git a/src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.Windows.cs b/src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.Windows.cs
@@ -691,7 +691,7 @@ private static StringBuilder BuildCommandLine(string executableFileName, string
 
             if (!string.IsNullOrEmpty(arguments))
             {
-                commandLine.Append(" ");
+                commandLine.Append(' ');
                 commandLine.Append(arguments);
             }
 

diff --git a/src/libraries/System.Diagnostics.TraceSource/src/System/Diagnostics/TraceListener.cs b/src/libraries/System.Diagnostics.TraceSource/src/System/Diagnostics/TraceListener.cs
@@ -201,11 +201,11 @@ public virtual void Fail(string message, string detailMessage)
         {
             StringBuilder failMessage = new StringBuilder();
             failMessage.Append(SR.TraceListenerFail);
-            failMessage.Append(" ");
+            failMessage.Append(' ');
             failMessage.Append(message);
             if (detailMessage != null)
             {
-                failMessage.Append(" ");
+                failMessage.Append(' ');
                 failMessage.Append(detailMessage);
             }
 

diff --git a/...vices.AccountManagement/src/System/DirectoryServices/AccountManagement/AD/ADAMStoreCtx.cs b/...vices.AccountManagement/src/System/DirectoryServices/AccountManagement/AD/ADAMStoreCtx.cs
@@ -333,7 +333,7 @@ protected override string GetObjectClassPortion(Type principalType)
                         {
                             filter.Append("(objectClass=");
                             filter.Append(objectClass);
-                            filter.Append(")");
+                            filter.Append(')');
                         }
 
                         _cachedBindableObjectFilter = filter.ToString();

diff --git a/...ervices.AccountManagement/src/System/DirectoryServices/AccountManagement/AD/ADStoreCtx.cs b/...ervices.AccountManagement/src/System/DirectoryServices/AccountManagement/AD/ADStoreCtx.cs
@@ -1049,22 +1049,22 @@ private ResultSet FindByDate(Type subtype, string[] ldapAttributes, MatchType ma
 
                 foreach (string ldapAttribute in ldapAttributes)
                 {
-                    ldapFilter.Append("(");
+                    ldapFilter.Append('(');
 
                     switch (matchType)
                     {
                         case MatchType.Equals:
                             ldapFilter.Append(ldapAttribute);
-                            ldapFilter.Append("=");
+                            ldapFilter.Append('=');
                             ldapFilter.Append(ldapValue);
                             break;
 
                         case MatchType.NotEquals:
                             ldapFilter.Append("!(");
                             ldapFilter.Append(ldapAttribute);
-                            ldapFilter.Append("=");
+                            ldapFilter.Append('=');
                             ldapFilter.Append(ldapValue);
-                            ldapFilter.Append(")");
+                            ldapFilter.Append(')');
                             break;
 
                         case MatchType.GreaterThanOrEquals:
@@ -1080,24 +1080,24 @@ private ResultSet FindByDate(Type subtype, string[] ldapAttributes, MatchType ma
                             break;
 
                         case MatchType.GreaterThan:
-                            ldapFilter.Append("&");
+                            ldapFilter.Append('&');
 
                             // Greater-than-or-equals (or less-than-or-equals))
-                            ldapFilter.Append("(");
+                            ldapFilter.Append('(');
                             ldapFilter.Append(ldapAttribute);
                             ldapFilter.Append(matchType == MatchType.GreaterThan ? ">=" : "<=");
                             ldapFilter.Append(ldapValue);
-                            ldapFilter.Append(")");
+                            ldapFilter.Append(')');
 
                             // And not-equal
                             ldapFilter.Append("(!(");
                             ldapFilter.Append(ldapAttribute);
-                            ldapFilter.Append("=");
+                            ldapFilter.Append('=');
                             ldapFilter.Append(ldapValue);
                             ldapFilter.Append("))");
 
                             // And exists (need to include because of tristate LDAP logic)
-                            ldapFilter.Append("(");
+                            ldapFilter.Append('(');
                             ldapFilter.Append(ldapAttribute);
                             ldapFilter.Append("=*)");
                             break;
@@ -1110,7 +1110,7 @@ private ResultSet FindByDate(Type subtype, string[] ldapAttributes, MatchType ma
                             break;
                     }
 
-                    ldapFilter.Append(")");
+                    ldapFilter.Append(')');
                 }
 
                 ldapFilter.Append("))");

diff --git a/...countManagement/src/System/DirectoryServices/AccountManagement/AD/ADStoreCtx_LoadStore.cs b/...countManagement/src/System/DirectoryServices/AccountManagement/AD/ADStoreCtx_LoadStore.cs
@@ -628,13 +628,13 @@ private Principal FindPrincipalByIdentRefHelper(
                                 innerLdapFilter.Append(filterVal);
                     }
 
-                    innerLdapFilter.Append(")");
+                    innerLdapFilter.Append(')');
 
                     ldapFilter.Append(innerLdapFilter.ToString());
                 }
 
                 // Wrap off the filter
-                ldapFilter.Append(")");
+                ldapFilter.Append(')');
 
                 ds.Filter = ldapFilter.ToString();
                 GlobalDebug.WriteLineIf(GlobalDebug.Info, "ADStoreCtx", "FindPrincipalByIdentRefHelper: using LDAP filter {0}", ds.Filter);
@@ -1244,7 +1244,7 @@ protected static void CommaStringToLdapConverter(Principal p, string propertyNam
                 // Preexisting values that have not been removed.
                 // This also includes inserted values.
                 sb.Append(value);
-                sb.Append(",");
+                sb.Append(',');
             }
 
             // We have an extra comma at the end (assuming we added any values to the string).  Remove it.