Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (sysadvisor): get power data served by metric store sourced from malachite realtime metric server #720

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

h-w-chen
Copy link
Contributor

@h-w-chen h-w-chen commented Nov 12, 2024

What type of PR is this?

Feature: power aware advisor uses realtime power data originally from malachite. It has 3 major parts:

  • malachite client method to get power stats from metric service path realtime/power;
  • malachite_realtime provisioner which samples (in higher frequency) using malachite client and saves power metric in metric store;
  • a power reader adapted to get power data out of metric store;

What this PR does / why we need it:

part of power node agent, it is needed for power aware plugin to get the current power usage and hence identify whether further measures required to limit the power consumption comparing with the desired power target.

Which issue(s) this PR fixes:

NA

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 60.65574% with 48 lines in your changes missing coverage. Please review.

Project coverage is 55.95%. Comparing base (4df549f) to head (6b0676c).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
...tric/provisioner/malachite/realtime_provisioner.go 50.81% 25 Missing and 5 partials ⚠️
...etric/provisioner/malachite/client/client_power.go 73.52% 6 Missing and 3 partials ⚠️
...gin/poweraware/reader/metric_store_power_reader.go 65.21% 7 Missing and 1 partial ⚠️
.../agent/sysadvisor/plugin/poweraware/power_aware.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #720      +/-   ##
==========================================
+ Coverage   55.91%   55.95%   +0.03%     
==========================================
  Files         593      597       +4     
  Lines       67813    67950     +137     
==========================================
+ Hits        37918    38019     +101     
- Misses      25859    25885      +26     
- Partials     4036     4046      +10     
Flag Coverage Δ
unittest 55.95% <60.65%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@h-w-chen h-w-chen force-pushed the dev/pap-malachite-power-fetcher branch from 035bb36 to ee3f6f0 Compare November 12, 2024 23:39
@h-w-chen h-w-chen changed the title WIP: get power data served by metric store feat (sysadvisor): get power data served by metric store sourced from malachite realtime metric server Nov 13, 2024
@h-w-chen h-w-chen force-pushed the dev/pap-malachite-power-fetcher branch from 02999ea to 6b0676c Compare November 20, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants