Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and enhance QRM support for reclaim_cores with numa_binding #703

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

luomingmeng
Copy link
Collaborator

@luomingmeng luomingmeng commented Oct 8, 2024

What type of PR is this?

Enhancements

What this PR does / why we need it:

This MR introduces the following main changes to support reclaim_cores with numa_binding:

  • Extract common fields from AllocationInfo into metadata and util Refactor the QRM plugin state #702
  • Update plugin state via LW interface
  • Adapt CPU plugin for RNB admission and provision
  • Adapt memory plugin for RNB admission and provision
  • Support CPU suppression and eviction for RNB
  • Update CPU plugin for pod NUMA annotations
  • Enable CPU plugin to set cgroup path via Allocate Response annotations

Which issue(s) this PR fixes:

Special notes for your reviewer:

@luomingmeng luomingmeng added the enhancement New feature or request label Oct 8, 2024
@luomingmeng luomingmeng self-assigned this Oct 8, 2024
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 58.45697% with 560 lines in your changes missing coverage. Please review.

Project coverage is 56.06%. Comparing base (56959bd) to head (71f4538).

Files with missing lines Patch % Lines
...memory/dynamicpolicy/policy_allocation_handlers.go 50.64% 65 Missing and 12 partials ⚠️
...ugins/memory/dynamicpolicy/policy_hint_handlers.go 64.76% 62 Missing and 12 partials ⚠️
...qrm-plugins/cpu/dynamicpolicy/cpuadvisor/cpu.pb.go 3.94% 70 Missing and 3 partials ⚠️
...ns/cpu/dynamicpolicy/policy_allocation_handlers.go 58.26% 41 Missing and 12 partials ⚠️
...lugins/cpu/dynamicpolicy/policy_advisor_handler.go 45.16% 23 Missing and 11 partials ⚠️
...-plugins/cpu/dynamicpolicy/policy_hint_handlers.go 81.72% 26 Missing and 8 partials ⚠️
...in/qosaware/resource/memory/plugin/memory_guard.go 59.74% 30 Missing and 1 partial ⚠️
...agent/qrm-plugins/cpu/dynamicpolicy/state/state.go 43.90% 22 Missing and 1 partial ⚠️
...nt/qrm-plugins/memory/dynamicpolicy/state/state.go 61.81% 17 Missing and 4 partials ⚠️
...y/dynamicpolicy/reactor/numa_allocation_reactor.go 56.81% 13 Missing and 6 partials ⚠️
... and 16 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #703      +/-   ##
==========================================
+ Coverage   55.79%   56.06%   +0.26%     
==========================================
  Files         573      575       +2     
  Lines       66840    67875    +1035     
==========================================
+ Hits        37294    38051     +757     
- Misses      25575    25770     +195     
- Partials     3971     4054      +83     
Flag Coverage Δ
unittest 56.06% <58.45%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luomingmeng luomingmeng changed the title cpu & memory advisor svc support numa headroom qrm support reclaim_cores with numa_binding Oct 8, 2024
@luomingmeng luomingmeng changed the title qrm support reclaim_cores with numa_binding Refactor and enhance QRM support for reclaim_cores with numa_binding Oct 8, 2024
@luomingmeng luomingmeng force-pushed the dev/support-reclaimed-numa-binding branch from 1e950ec to 31e8057 Compare October 9, 2024 10:55
@luomingmeng luomingmeng force-pushed the dev/support-reclaimed-numa-binding branch 2 times, most recently from 2b6749e to cd4ebfd Compare October 11, 2024 11:47
@luomingmeng luomingmeng force-pushed the dev/support-reclaimed-numa-binding branch 15 times, most recently from eee1958 to e1a84d6 Compare October 15, 2024 13:00
@luomingmeng luomingmeng force-pushed the dev/support-reclaimed-numa-binding branch 9 times, most recently from 0c0b48e to fa897b9 Compare October 21, 2024 11:21
@luomingmeng luomingmeng force-pushed the dev/support-reclaimed-numa-binding branch 8 times, most recently from 0c6b9ef to 4f23f62 Compare October 22, 2024 13:54
@luomingmeng luomingmeng force-pushed the dev/support-reclaimed-numa-binding branch from 4f23f62 to 71f4538 Compare October 22, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant