Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(overcommit): predict overcommit ratio by spd portrait #652

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

WangZzzhe
Copy link
Collaborator

What type of PR is this?

Enhancements

What this PR does / why we need it:

predict overcommit ratio by spd portrait

Special notes for your reviewer:

pr should be rebased after kubewharf/katalyst-api#93 merged

@WangZzzhe WangZzzhe force-pushed the dev/overcommit-predict-by-spd-portrait branch from c3c58d8 to 382d337 Compare July 18, 2024 08:43
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 76.72176% with 169 lines in your changes missing coverage. Please review.

Project coverage is 56.98%. Comparing base (782d443) to head (382d337).
Report is 18 commits behind head on main.

Files Patch % Lines
pkg/controller/overcommit/prediction/prediction.go 78.20% 45 Missing and 23 partials ⚠️
...er/overcommit/prediction/provider/prom/provider.go 56.73% 42 Missing and 3 partials ⚠️
pkg/controller/overcommit/prediction/workload.go 68.53% 19 Missing and 9 partials ⚠️
...g/controller/overcommit/prediction/common/types.go 67.64% 6 Missing and 5 partials ⚠️
pkg/util/overcommit/overcommit.go 27.27% 7 Missing and 1 partial ⚠️
...vercommit/prediction/predictor/nsigma/predictor.go 90.38% 3 Missing and 2 partials ⚠️
...oller/overcommit/prediction/predictor/interface.go 71.42% 1 Missing and 1 partial ⚠️
...ercommit/prediction/provider/prom/fake_provider.go 77.77% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             main     #652     +/-   ##
=========================================
  Coverage   56.98%   56.98%             
=========================================
  Files         544      560     +16     
  Lines       51826    53554   +1728     
=========================================
+ Hits        29531    30519    +988     
- Misses      18557    19227    +670     
- Partials     3738     3808     +70     
Flag Coverage Δ
unittest 56.98% <76.72%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WangZzzhe WangZzzhe added enhancement New feature or request workflow/need-review review: test succeeded, need to review labels Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant