Skip to content

Commit

Permalink
Merge pull request #729 from cheney-lin/fix/move_pages
Browse files Browse the repository at this point in the history
fix(*): Remove the constraints on move pages
  • Loading branch information
xu282934741 authored Nov 28, 2024
2 parents 9d63b39 + 5cd636d commit 76e6c12
Showing 1 changed file with 0 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,6 @@ const (

// MovePagesAcceptableTimeCost is acceptable time cost of each move pages is 20ms
MovePagesAcceptableTimeCost = 20
MBytes = 1024 * 1024

// MinRSSSkipMigrate is min rss size to skip migrate the process numa pages.
MinRSSSkipMigrate = 10 * MBytes

SystemNodeDir = "/sys/devices/system/node/"
ProcDir = "/proc"
Expand Down Expand Up @@ -252,11 +248,6 @@ func MovePagesForProcess(ctx context.Context, procDir string, pid int, srcNumas
return err
}

// skip process whose rss is below threshold.
if pidSmapsInfo.totalRss < MinRSSSkipMigrate {
return nil
}

srcNumasBitSet, err := bitmask.NewBitMask(srcNumas...)
if err != nil {
return fmt.Errorf("failed to NewBitMask allowd numas %+v", srcNumas)
Expand Down

0 comments on commit 76e6c12

Please sign in to comment.