fix(app): add version name ordering in app version lists (#4442)

Add 'versionName' ordering parameter to useAppVersionList hook calls in BasicInfoForm and AppVersionSelector components to ensure consistent version display order Signed-off-by: leioy <[email protected]>
kubesphere · Jan 17, 2025 · 3f087ab · 3f087ab
1 parent 6822c58
commit 3f087ab
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 5 deletions.
diff --git a/packages/shared/src/components/Apps/AppForms/AppBaseInfoForm/BasicInfoForm/index.tsx b/packages/shared/src/components/Apps/AppForms/AppBaseInfoForm/BasicInfoForm/index.tsx
@@ -45,7 +45,10 @@ export function BasicInfoForm({
 }: Props): JSX.Element {
   const { workspace } = useParams();
   const [initData, setInitData] = useState<Partial<AppBasicInfoFormData>>();
-  const { data: versions } = useAppVersionList({ appName }, { status: versionStatus });
+  const { data: versions } = useAppVersionList(
+    { appName },
+    { status: versionStatus, order: 'versionName' },
+  );
   const sortedVersions = useMemo(
     () =>
       (versions || [])

diff --git a/packages/shared/src/components/Apps/AppVersionSelector/index.tsx b/packages/shared/src/components/Apps/AppVersionSelector/index.tsx
@@ -28,10 +28,15 @@ export function AppVersionSelector({
   selectedVersionChange,
 }: Props): JSX.Element {
   const [selectedVersion, setSelectedVersion] = useState<string>('');
-  const { data: versions = [] } = useAppVersionList({
-    workspace,
-    appName: appDetail.metadata.name,
-  });
+  const { data: versions = [] } = useAppVersionList(
+    {
+      workspace,
+      appName: appDetail.metadata.name,
+    },
+    {
+      order: 'versionName',
+    },
+  );
   const versionOptions = useMemo(() => {
     return versions?.map(({ metadata, spec }) => ({
       label: spec.versionName,