Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(trace-mode): added concepts, config, edit misc pages #4043

Merged
merged 5 commits into from
Oct 9, 2024
Merged

docs(trace-mode): added concepts, config, edit misc pages #4043

merged 5 commits into from
Oct 9, 2024

Conversation

adnanrahic
Copy link
Contributor

@adnanrahic adnanrahic commented Oct 8, 2024 •
edited
Loading

This PR:

Adds:

  • Concepts/Traces page
  • Config/Trace Mode page
  • Concepts/Triggers page
  • Config/OTLP page

Edits:

  • Config/Trace Ingestion

Changes

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Loom video

Add your loom video here if your work can be visualized

@vercel Vercel
Copy link

vercel bot commented Oct 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tracetest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2024 0:25am

@adnanrahic adnanrahic added the documentation Improvements or additions to documentation label Oct 8, 2024
jfermi
jfermi reviewed Oct 8, 2024
View reviewed changes
Copy link
Contributor

@jfermi jfermi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small editing suggestion.

@adnanrahic
Copy link
Contributor Author

Nice thanks!

@adnanrahic adnanrahic merged commit 67a46f1 into main Oct 9, 2024
40 checks passed
@adnanrahic adnanrahic deleted the docs-trace-mode-1 branch October 9, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfermi jfermi jfermi left review comments

@danielbdias danielbdias danielbdias approved these changes

@xoscar xoscar Awaiting requested review from xoscar

@kdhamric kdhamric Awaiting requested review from kdhamric

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adnanrahic @danielbdias @jfermi