Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(tempodb): Adding max size for received messages to 10MB #4026

Merged
merged 1 commit into from
Sep 20, 2024
Merged

chore(tempodb): Adding max size for received messages to 10MB #4026

merged 1 commit into from
Sep 20, 2024

Conversation

xoscar
Copy link
Contributor

@xoscar xoscar commented Sep 19, 2024

This PR temporary increases the max size of messages to 10MB, while we work on a way to paginate results from Tempo

Changes

  • Adds max received option to 10MB

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@vercel Vercel
Copy link

vercel bot commented Sep 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tracetest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2024 10:17pm

@xoscar xoscar self-assigned this Sep 19, 2024
@xoscar xoscar marked this pull request as ready for review September 19, 2024 22:17
mathnogueira
mathnogueira approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@mathnogueira mathnogueira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It's worth noting that the tempo server must be changed as well. So if we find any problem like that in prod, we need to ask the user to increase the max send size of the server to match our agent max size.

@xoscar xoscar merged commit 0253f9f into main Sep 20, 2024
40 checks passed
@xoscar xoscar deleted the chore-updating-max-size-msg-tempo branch September 20, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathnogueira mathnogueira mathnogueira approved these changes

Assignees

@xoscar xoscar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xoscar @mathnogueira