feat(cli): allow selecting resource type when running multiple files #4020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
schoren
commented
Sep 17, 2024
| func (o orchestrator) runByFiles(ctx context.Context, opts RunOptions, resourceFetcher runner.ResourceFetcher, vars *varset.VarSets, varsID string, runGroupID string) ([]any, []runner.RunResult, error) { | ||
| resources := make([]any, 0) | ||
| runsResults := make([]runner.RunResult, 0) | ||
| var mainErr error | ||
|
|
||
| hasDefinitionFilesDefined := opts.DefinitionFiles != nil && len(opts.DefinitionFiles) > 0 | ||
| hasDefinitionFilesDefined := len(opts.DefinitionFiles) > 0 |
There was a problem hiding this comment.
this is not related, but it was causing an annoying warning
schoren
commented
Sep 17, 2024
| @@ -41,7 +41,6 @@ func ReadDirFileNames(path string) []string { | |||
|
|
|||
| var result []string | |||
| for _, file := range files { | |||
| // TODO: add validation for file extensions, tracetest runnable definitions (?) | |||
There was a problem hiding this comment.
this should not be handled here, and this PR addresses this todo
schoren
requested review from
xoscar and
mathnogueira
and removed request for
xoscar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the cli to filter files by resource types when running an entire directory. This allows to use a single command to launch multiple testsuites from a directory that also contains tests. For example:
Until now, running
tracetest run -f testswould cause to run01_step_1.yaml,02_step_2.yamlandfeature_test_suite.yaml. This might not be desirableNow, running
tracetest run testsuite -f testswould cause to only runfeature_test_suite.yaml.Changes
Fixes
Checklist
Loom video
Add your loom video here if your work can be visualized