fix: correctly display general errors #3995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
danielbdias-kubeshop
approved these changes
Aug 28, 2024
schoren
commented
Aug 28, 2024
| @@ -357,29 +356,3 @@ func getRequiredGates(gates []string) []openapi.SupportedGates { | |||
|
|
|||
| return requiredGates | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
this code was unused
schoren
commented
Aug 28, 2024
| @@ -296,8 +296,6 @@ func (a orchestrator) writeJUnitReport(ctx context.Context, r Runner, result Run | |||
| return err | |||
| } | |||
|
|
|||
| var source = "cli" | |||
There was a problem hiding this comment.
this var was unused
xoscar
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the error handling of the CLI for the run command. It now allows displaying an error instead of silently failing.
It also attempts to parse the error response from the server as a structured error to display nicer messages when possible
Changes
Fixes
Checklist
Loom video
Add your loom video here if your work can be visualized