Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore updating xray examples #3964

Merged
merged 6 commits into from
Aug 14, 2024
Merged

Chore updating xray examples #3964

merged 6 commits into from
Aug 14, 2024

Conversation

xoscar
Copy link
Contributor

@xoscar xoscar commented Aug 13, 2024 •
edited
Loading

This PR updates the xray examples

Changes

  • updates the x-ray examples

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@vercel Vercel
Copy link

vercel bot commented Aug 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tracetest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 14, 2024 3:26pm

@xoscar xoscar marked this pull request as ready for review August 13, 2024 22:15
@xoscar xoscar self-assigned this Aug 13, 2024
adnanrahic
adnanrahic approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@adnanrahic adnanrahic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few links need fixing. All good to merge otherwise.

docs/docs/examples-tutorials/recipes/running-tracetest-with-aws-x-ray.mdx Outdated Show resolved Hide resolved
docs/docs/examples-tutorials/recipes/running-tracetest-with-aws-x-ray-pokeshop.mdx Outdated Show resolved Hide resolved
docs/docs/examples-tutorials/recipes/running-tracetest-with-aws-x-ray-adot.mdx Outdated Show resolved Hide resolved
docs/docs/examples-tutorials/recipes/running-tracetest-with-aws-x-ray-adot.mdx Outdated Show resolved Hide resolved
docs/docs/examples-tutorials/recipes/running-tracetest-with-aws-x-ray.mdx Outdated Show resolved Hide resolved
@xoscar xoscar merged commit 5de89bf into main Aug 14, 2024
38 checks passed
@xoscar xoscar deleted the chore-updating-xray-examples branch August 14, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfermi jfermi jfermi approved these changes

@adnanrahic adnanrahic adnanrahic approved these changes

@kdhamric kdhamric Awaiting requested review from kdhamric

Assignees

@xoscar xoscar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xoscar @adnanrahic @jfermi