Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(examples/docs): Updating jaeger x node.js example to be the initial template #3958

Merged
merged 4 commits into from
Aug 13, 2024

Conversation

xoscar
Copy link
Contributor

@xoscar xoscar commented Aug 12, 2024

This PR updates the nodejs x jaeger example to be the first templated recipe/example

Changes

  • Adds resources folder with automated provisioning
  • Updates docker compose setup
  • Updates .env.template
  • Updates links to grab the token

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Loom video

https://www.loom.com/share/d9ce986f2e8c445a9b49b52c09c50bfa

@xoscar xoscar self-assigned this Aug 12, 2024
Copy link

vercel bot commented Aug 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tracetest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 13, 2024 3:50pm

@xoscar xoscar requested review from adnanrahic and kdhamric August 12, 2024 22:06
@xoscar xoscar marked this pull request as ready for review August 12, 2024 22:06
Copy link
Contributor

@adnanrahic adnanrahic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions.

# Get the required information here: https://app.tracetest.io/retrieve-token

TRACETEST_TOKEN="<YOUR_TRACETEST_TOKEN>"
TRACETEST_ENVIRONMENT_ID="<YOUR_ENV_ID>"
```

The OpenTelemetry tracing is contained in the `tracing.otel.grpc.js` or `tracing.otel.http.js` files. Traces will be sent to Tracetest Agent.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The OpenTelemetry tracing is contained in the `tracing.otel.grpc.js` or `tracing.otel.http.js` files. Traces will be sent to Tracetest Agent.
The OpenTelemetry tracing is contained in the `tracing.otel.grpc.js` or `tracing.otel.http.js` files.

tracetest run test -f ./test-api.yaml
```
This will:
1. Start the Node.js app the OpenTelemetry Collector and send the traces to Jaeger.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. Start the Node.js app the OpenTelemetry Collector and send the traces to Jaeger.
1. Start the Node.js app, the OpenTelemetry Collector, and send the traces to Jaeger.

This will:
1. Start the Node.js app the OpenTelemetry Collector and send the traces to Jaeger.
2. Start the Tracetest Agent.
3. Configure the tracing backend and create the Tests in your environment.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
3. Configure the tracing backend and create the Tests in your environment.
3. Configure the tracing backend and create tests in your environment.

@xoscar xoscar merged commit 7b34bb0 into main Aug 13, 2024
38 checks passed
@xoscar xoscar deleted the chore-standard-recipe-example branch August 13, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants