feat(cli): reauthenticate user in case of invalid token #3643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Closed
xoscar
approved these changes
Feb 16, 2024
| flags.EnvironmentID = envID | ||
| } | ||
|
|
||
| spew.Dump(flags) |
| } | ||
|
|
||
| func handleAuthError(ctx context.Context) { | ||
| ui.DefaultUI.Warning("Your authentication token has expired, please log in again.") |
There was a problem hiding this comment.
Does this handles environment tokens expiration?
There was a problem hiding this comment.
That's a good question. I didn't test that case, but this mechanism is triggered whenever the server returns a 401. So if an expired token throws a 401, then this will be triggered.
jorgeepc
approved these changes
Feb 16, 2024
|
I watched the video - looks awesome @schoren ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the error handling when the server does not accept the JWT token for whatever reason (corrupted config file, expired token, anything that makes the server return a 401 code).
When an auth error happens, the authentication flow begins, and the issued command is automatically rerun with the new credentials.
For the case of the
startcmd, this new behaviour was causing the cli to show 2 times the org/env selector: once for the new auth and another one for thestartcommand (it shows the selector when started unless org/env are passed via flags).To overcome this issue, I added some context magic to pass the values around in a relatively seamless way so this command can pick the values and not ask the user 2 times.
Changes
Fixes
Checklist
Loom video
https://www.loom.com/share/cf956f7d668f475baa22678d4ac6a7bf