Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(otlp): Increasing the grpc server data max size #3641

Merged
merged 1 commit into from
Feb 14, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion server/otlp/grpc_server.go
Original file line number Diff line number Diff line change
@@ -36,7 +36,11 @@ func (s *grpcServer) SetLogger(logger *zap.Logger) {
}

func (s *grpcServer) Start() error {
s.gServer = grpc.NewServer()
size := 1024 * 1024 * 50
s.gServer = grpc.NewServer(
grpc.MaxSendMsgSize(size),
grpc.MaxRecvMsgSize(size),
)
listener, err := net.Listen("tcp", s.addr)
if err != nil {
return fmt.Errorf("cannot listen on address %s: %w", s.addr, err)

Unchanged files with check annotations Beta

const TestPanel = ({run, testId, runEvents}: IProps) => {
const [query, updateQuery] = useSearchParams();
const {selectedSpan, onSetFocusedSpan, onSelectSpan} = useSpan();

Check warning on line 41 in web/src/components/RunDetailTest/TestPanel.tsx

GitHub Actions / WebUI unit tests

'onSelectSpan' is assigned a value but never used
const {remove, revert, selectedTestSpec, setSelectedSpec, setSelectorSuggestions, setPrevSelector, specs} =
useTestSpecs();
const {isOpen: isTestSpecFormOpen, formProps, onSubmit, open, close, isValid, onIsValid} = useTestSpecForm();
// listens to all form changes
const data = Form.useWatch([], form);
const isOtlpBased = useMemo(() => DataStoreService.getIsOtlpBased(form.getFieldsValue()), [data]);

Check warning on line 38 in web/src/components/TestConnectionStatus/hooks/useTestConnnectionStatus.ts

GitHub Actions / WebUI unit tests

React Hook useMemo has a missing dependency: 'form'. Either include it or remove the dependency array
const onStartPolling = useCallback(async () => {
setPollInterval(POLL_INTERVAL);
if (isOtlpBased) {
onStartPolling();
}
}, [isOtlpBased]);

Check warning on line 67 in web/src/components/TestConnectionStatus/hooks/useTestConnnectionStatus.ts

GitHub Actions / WebUI unit tests

React Hook useEffect has missing dependencies: 'onReset' and 'onStartPolling'. Either include them or remove the dependency array
useEffect(() => {
/// if we are polling, refresh the provider result with the response information
return () => {
onCancel();
};
}, []);

Check warning on line 62 in web/src/components/TestOutputForm/TestOutputForm.tsx

GitHub Actions / WebUI unit tests

React Hook useEffect has a missing dependency: 'onCancel'. Either include it or remove the dependency array. If 'onCancel' changes too often, find the parent component that defines it and wrap that definition in useCallback
const onAttributeFocus = (view: EditorView) => {
if (!view?.state.doc.length) delay(() => startCompletion(view!), 0);
return () => {
onCancel();
};
}, []);

Check warning on line 77 in web/src/components/TestSpecForm/TestSpecForm.tsx

GitHub Actions / WebUI unit tests

React Hook useEffect has missing dependencies: 'assertions', 'name', 'onCancel', 'onValuesChange', and 'selector'. Either include them or remove the dependency array. If 'onCancel' changes too often, find the parent component that defines it and wrap that definition in useCallback
useEffect(() => {
form.setFieldsValue({
useEffect(() => {
onValidateTest({}, initialValues);
}, []);

Check warning on line 54 in web/src/pages/CreateTest/Content.tsx

GitHub Actions / WebUI unit tests

React Hook useEffect has missing dependencies: 'initialValues' and 'onValidateTest'. Either include them or remove the dependency array
const tabBarExtraContent = useMemo(
() => ({