feat(cli): Token Support #3255
Merged
feat(cli): Token Support #3255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgeepc
reviewed
Oct 12, 2023
cli/cmd/start_cmd.go
Outdated
| @@ -49,6 +52,7 @@ func init() { | |||
| startCmd.Flags().StringVarP(&saveParams.organizationID, "organization", "", "", "organization id") | |||
| startCmd.Flags().StringVarP(&saveParams.environmentID, "environment", "", "", "environment id") | |||
| startCmd.Flags().StringVarP(&saveParams.agentApiKey, "api-key", "", "", "agent api key") | |||
| startCmd.Flags().StringVarP(&saveParams.tokenApiKey, "token", "", defaultToken, "token api key") | |||
There was a problem hiding this comment.
cli-api-keyinstead of token?
There was a problem hiding this comment.
I'm kind of late to this discussion. But I think that cli-api-key is too close to api-key and it's hard to understand what's the difference between them.
I would suggest using either token or a more meaningful name for this flag (which I have no suggestions yet). The idea behind using token is that the user will get the value from the Token tab, so will be more intuitive for the user to create a connection between the value and the flag they need to use.
There was a problem hiding this comment.
I agree with this statement too, I think we can go with token as it matches the SaaS cloud, then in the future we can decide to change it
mathnogueira
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds token support for the
tracetest startcommandChanges
Checklist
Loom video
https://www.loom.com/share/a1405279a47a429cae4fe0bb8df25233