Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(server): add composite primary key for single row resources #3155

Merged
merged 8 commits into from
Sep 18, 2023
Merged

fix(server): add composite primary key for single row resources #3155

merged 8 commits into from
Sep 18, 2023

Conversation

jorgeepc
Copy link
Contributor

@jorgeepc jorgeepc commented Sep 13, 2023 •
edited
Loading

This PR fixes the single row resources (datastore, demo, pollingprofile, analyzer and testrunner) repository by adding a composite primary key (id + tenant_id).

Changes

  • add composite primary key for datastore, pollingprofile, analyzer and testrunner
  • fix delete query
  • fix insert query

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@jorgeepc jorgeepc changed the title fix(server): add composite primary key for single row resources fix(server): fix single row resources Sep 13, 2023
@jorgeepc jorgeepc changed the title fix(server): fix single row resources fix(server): add composite primary key for single row resources Sep 15, 2023
@jorgeepc jorgeepc marked this pull request as ready for review September 15, 2023 18:42
@jorgeepc jorgeepc self-assigned this Sep 18, 2023
schoren
schoren approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@schoren schoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

xoscar
xoscar approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@xoscar xoscar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ @jorgeepc

@jorgeepc jorgeepc merged commit 7500911 into main Sep 18, 2023
38 checks passed
@jorgeepc jorgeepc deleted the fix-composite-primary-key branch September 18, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbdias danielbdias danielbdias approved these changes

@xoscar xoscar xoscar approved these changes

@schoren schoren schoren approved these changes

Assignees

@jorgeepc jorgeepc

Labels
backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jorgeepc @schoren @xoscar @danielbdias